Get next available stream ID more efficiently #338
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #338 +/- ##
===========================================
- Coverage 100.00% 99.95% -0.05%
===========================================
Files 22 23 +1
Lines 4553 4534 -19
===========================================
- Hits 4553 4532 -21
- Misses 0 2 +2
... and 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
The [`itertools.count()`](https://docs.python.org/3/library/itertools.html#itertools.count) not only satisfies [stream ID requirement](https://www.rfc-editor.org/rfc/rfc9000.html#name-stream-types-and-identifier), but also runs faster, because it remembers current stream ID and is implemented by C.
|
I don't think this is correct, you are changing the state of the connection on every call, which is not the current behaviour? |
|
Closing in favour of #403 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
itertools.count()not only satisfies stream ID requirement, but also runs faster, because it remembers current stream ID and is implemented by C.