Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOP_SENDING support #193

Closed
rakbladsvalsen opened this issue May 28, 2021 · 1 comment
Closed

STOP_SENDING support #193

rakbladsvalsen opened this issue May 28, 2021 · 1 comment

Comments

@rakbladsvalsen
Copy link

rakbladsvalsen commented May 28, 2021

Hi! I see that there's basic support for this kind of frame. It appears to be handled, but it doesn't seem to fire any events back to the user, it just gets "processed" away by _handle_stop_sending_frame but that's it.

I didn't test this thoroughly but it seems that even if the remote peer sends us a STOP_SENDING frame we're still able to send data on the same stream_id. From what I've read, some QUIC implementations will send back a STREAM_RESET once they receive a STOP_SENDING frame. 1

I half-implemented this missing feature (literally QuicConnection.stop_sending(stream_id, error_code) so I could send this frame) and even though I'm able to properly send the frame it just gets ACK'd away. I indeed confirmed this by analyzing the traffic with wireshark and yeah, it is just ACK'd without anything changing internally.

I have a question (not related to this issue). Are there any plans to make this library any faster? I noticed that there are quite a lot of simple data classes, which we could probably rewrite using ctypes. We could port the whole thing to Cython. If you have any future plans to do so I'm in.

@sethmlarson
Copy link

Also throwing mypyc into the ring of potential speedup routes.

jlaine added a commit to jlaine/aioquic that referenced this issue Jul 19, 2021
jlaine added a commit to jlaine/aioquic that referenced this issue Jul 19, 2021
jlaine added a commit to jlaine/aioquic that referenced this issue Jul 19, 2021
@jlaine jlaine closed this as completed in 55b531a Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants