-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuration overrides #383
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we are already talking about that I close the revision here and we can start another one ;p
co-authored by: Adrian Alcolea <AdrianAlcolea@users.noreply.github.com>
I also had the PYTHON_PATH... I think we should probably just bake that into the docker image, though? Since it's required for the image to function even if no code is mounted... otherwise, things seem to work. All connectors are able to import data now and I can search both directly with the API and through the elastic search endpoints. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, everything works for me now =)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works well for me now.
This PR adds documentation (and the possibility) to allow overrides for the
src/config.toml
configuration and the.env
configuration. This is useful, because then you can customize your own deployment (also production), without affecting files which are checked into git, which means:I also removed the passing around of environment variables between all docker images, as the relevant variables were already also passed through the
environment
field. Now containers are only aware of the variables they need.How to Test
Change some configurations in
src/config.override.toml
andoverride.env
as described in the documentation with some custom options (whatever you are already using, or something new just to test).up
the containers, poke around,down
the containers.