Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add security linting, request timeouts #376

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Add security linting, request timeouts #376

merged 4 commits into from
Oct 29, 2024

Conversation

PGijsbers
Copy link
Collaborator

I added security linting through ruff. This is a reimplementation of (most) bandit checks, but in Rust. We will probably move over to ruff for all linting and formatting since its much faster, which is why I opted to use Ruff here instead of Bandit as was recommended in the audit.

@PGijsbers PGijsbers added the enhancement New feature or request label Oct 28, 2024
@PGijsbers PGijsbers requested a review from Taniya-Das October 29, 2024 09:35
Copy link
Collaborator

@Taniya-Das Taniya-Das left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a quick look at the changes, and they make sense to me, hence approving the PR. Let me know if you would like to take a more detailed look.

@PGijsbers PGijsbers merged commit 3f57b2e into develop Oct 29, 2024
4 checks passed
@PGijsbers PGijsbers deleted the precommit/bandit branch October 29, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants