Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keycloak aiod theme initial commit #339

Merged
merged 5 commits into from
Jul 29, 2024
Merged

Add keycloak aiod theme initial commit #339

merged 5 commits into from
Jul 29, 2024

Conversation

mrorro
Copy link
Collaborator

@mrorro mrorro commented Jun 27, 2024

No description provided.

@PGijsbers
Copy link
Collaborator

Is this PR ready for review? If so, how should it be reviewed? I wanted to try to review this but wasn't sure. I pulled in the changes and spun up the containers, but neither the REST API authentication nor the Keycloak Admin panel has any visual changes for me.

@PGijsbers PGijsbers added the question Further information is requested label Jul 25, 2024
@mrorro
Copy link
Collaborator Author

mrorro commented Jul 25, 2024

yes, it's ready. To see the changes you can log with the REST API using the first option: OpenIdConnect (OAuth2, authorization_code with PKCE). The keycloak admin has not changed. changes can be seen also trying to login to http://localhost/aiod-auth/realms/aiod/account/
account management has not changed too, for it would be better to update keycloak to v 25, but for this I guess it's better another PR

Copy link
Collaborator

@PGijsbers PGijsbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pointers! LGTM :)

@mrorro mrorro merged commit 9049328 into develop Jul 29, 2024
1 check passed
@mrorro mrorro deleted the keycloak-theme branch July 29, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants