forked from openml-labs/server-demo
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/zenodo connector rate limits #272
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstead of dumping them
…l resume from last processed instead of last dataset.
…ct with logs that were also removed after creation.
… list. Also, change on _distributions()
andrejridzik
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfixes:
Solution: I separated fetching all records from processing them, and added a timer to stop fetching before the given expiration.
Solution: I pass the timestamp of the last processed record to the state. This way the next iteration will start from the last record, instead of
to_excl_current
, which is defined as next cycle (previousfrom_incl + time_per_loop
)Solution: I used decorators on the fetching methods to define the limits and sleep and retry to avoid raising the
429 error
.KeyError
s due to missing fields were not properly addressed. This were all passed to the log files making it less readable to debug and quickly overloads the log files.Solution: I used the dictionary
.get()
method to return aNone
or default value to be evaluated subsequently.Changes: