Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/openml connector offset #270

Merged
merged 4 commits into from
Feb 20, 2024
Merged

Conversation

jsmatias
Copy link
Member

Bugfixes:

  1. Issue OpenML connector doesn't recognise last asset and keeps increasing offset #266 - OpenML returns a response with status code 412, when a list is not found.
  • Solved by returning a RecordError with a HttpError to the main loop. When this happens, the loop is interrupted without adding an unit to the counter, which is added to the state[offset].
  • Tests added to check the state after a response with status_code=412
  1. The _distributions() function was returning an empty list when all the three fields: dependencies, installation_notes, and binary_url had not None values, instead of the opposite.

@jsmatias jsmatias added the bug Something isn't working label Feb 14, 2024
@jsmatias jsmatias self-assigned this Feb 14, 2024
@jsmatias jsmatias merged commit 8accdb7 into develop Feb 20, 2024
1 check passed
@andrejridzik andrejridzik deleted the bugfix/openml-connector-offset branch October 29, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenML connector doesn't recognise last asset and keeps increasing offset
2 participants