Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement/minor changes #268

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Improvement/minor changes #268

merged 3 commits into from
Feb 14, 2024

Conversation

jsmatias
Copy link
Member

@jsmatias jsmatias commented Feb 7, 2024

Three minor changes are included:

  1. Bugfix: An error message on Zenodo uploader was truncated due to line break.
  2. I added version tags to the connector.log files to facilitate debugging.
  3. Changed the operator in the connectors/huggingface/datasets.sh to avoid deletion of the logs when the Docker container is restarted.

@jsmatias jsmatias self-assigned this Feb 7, 2024
soniasantiago
soniasantiago approved these changes Feb 14, 2024
View reviewed changes
Copy link

@soniasantiago soniasantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine. Thanks for the fixes and improvements!

@jsmatias jsmatias merged commit 192380b into develop Feb 14, 2024
1 check passed
@andrejridzik andrejridzik deleted the improvement/minor-changes branch October 29, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soniasantiago soniasantiago soniasantiago approved these changes

Assignees

@jsmatias jsmatias

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsmatias @soniasantiago