Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos #258

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Fix typos #258

merged 1 commit into from
Jan 23, 2024

Conversation

PGijsbers
Copy link
Collaborator

The default is actually only-if-empty and data is not a valid argument for that parameter.
Notice->Notify is a simple typo.

@PGijsbers PGijsbers requested a review from Taniya-Das January 22, 2024 14:41
Taniya-Das
Taniya-Das approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@Taniya-Das Taniya-Das left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing.

@Taniya-Das Taniya-Das merged commit 46a5213 into develop Jan 23, 2024
1 check passed
@andrejridzik andrejridzik deleted the PGijsbers-patch-1 branch October 29, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Taniya-Das Taniya-Das Taniya-Das approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PGijsbers @Taniya-Das