Bugfix: Huggingface dataset uploader #216
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Andrej found a bug in the HuggingFace uploader: as
repo_id
it usedusername/dataset_name_cleaned
, while you'd expect the dataset_name to already include theusername
.In this PR, this is fixed:
dataset.name
asrepo_id
, thedataset.platform_resource_identifier
is used, because this identifier should uniquely identify the dataset on HF.platform
of the mentioned dataset is not "huggingface" or thedataset.platform_resource_identifier
is not a valid<namespace>/<dataset_name>
.