Bugfixes for platform delete #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ere, because they will not be indexed by ES, and this makes it easier to keep the unique index platform.name, easy for foreign key constraints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making sure platform deletion works as planned.
Decided to use hard-delete for platforms. That should not be problematic (platforms are not indexed by ES anyway), and this makes it easier to keep the unique index platform.name, easy for foreign key constraints.
The usage of the decorator
@declared_attris suggested by sqlalchemy (https://docs.sqlalchemy.org/en/13/orm/extensions/declarative/api.html#sqlalchemy.ext.declarative.declared_attr) instead ofclassproperty. I just adopted this, because SqlAlchemy suggests it, and becauseclasspropertywas giving errors.