Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/connector sync #100

Merged
merged 54 commits into from
Aug 23, 2023
Merged

Feature/connector sync #100

merged 54 commits into from
Aug 23, 2023

Conversation

arejula27
Copy link
Collaborator

@arejula27 arejula27 commented Jul 13, 2023

This Pr refactos the current connectors, separating them from the server and exposing a uniformed interface for executing them from external scrips.

For completing the issue #16 is needed more development:

  • Create the script src/connectors/synchronization.py
  • Create synchronize.sh

@arejula27 arejula27 requested a review from josvandervelde July 13, 2023 14:14
Copy link

@josvandervelde josvandervelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A step in the right direction :)

src/connectors/abstract/resource_connector_by_date.py Outdated Show resolved Hide resolved
src/connectors/example/example_dataset_connector.py Outdated Show resolved Hide resolved
src/connectors/example/example_dataset_connector.py Outdated Show resolved Hide resolved
src/connectors/example/example_dataset_connector.py Outdated Show resolved Hide resolved
src/connectors/example/example_connector.py Outdated Show resolved Hide resolved
src/tests/connectors/zenodo/test_get_datasets_zenodo.py Outdated Show resolved Hide resolved
src/connectors/zenodo/zenodo_dataset_connector.py Outdated Show resolved Hide resolved
src/connectors/zenodo/zenodo_dataset_connector.py Outdated Show resolved Hide resolved
src/main.py Outdated Show resolved Hide resolved
src/connectors/abstract/resource_connector_by_date.py Outdated Show resolved Hide resolved
src/connectors/example/example_dataset_connector.py Outdated Show resolved Hide resolved
src/connectors/example/example_connector.py Outdated Show resolved Hide resolved
src/connectors/openml/openml_dataset_connector.py Outdated Show resolved Hide resolved
src/connectors/example/example_dataset_connector.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Taniya-Das Taniya-Das left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@josvandervelde josvandervelde merged commit 21c9498 into develop Aug 23, 2023
@josvandervelde josvandervelde deleted the feature/connector-sync branch August 23, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants