Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlAlchemy 2.0.33 compatibility #360

Closed
PGijsbers opened this issue Sep 26, 2024 · 1 comment · Fixed by #361
Closed

SqlAlchemy 2.0.33 compatibility #360

PGijsbers opened this issue Sep 26, 2024 · 1 comment · Fixed by #361
Labels
bug Something isn't working pip dependencies update dependency version
Milestone
Yearly Review Rel...

Comments

@PGijsbers
Copy link
Collaborator

Burnt by using sqlalchemy internals, our system broke with 2.0.33 as _extract_mapped_subtype now can return ForwardRef objects.
https://github.com/sqlalchemy/sqlalchemy/compare/rel_2_0_32..rel_2_0_33
@PGijsbers PGijsbers added bug Something isn't working pip dependencies update dependency version labels Sep 26, 2024
@PGijsbers
Copy link
Collaborator Author

Exposed by python -m pytest src/tests/connectors/huggingface/test_huggingface_dataset_connector.py::test_incorrect_citation

PGijsbers added a commit that referenced this issue Sep 26, 2024
@PGijsbers
Limit SqlAlchemy (#360)
fd2b4a6
@PGijsbers PGijsbers mentioned this issue Sep 26, 2024
Merged
@PGijsbers PGijsbers added this to the Yearly Review Release milestone Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working pip dependencies update dependency version
Projects
None yet
Milestone
Yearly Review Release
Development

Successfully merging a pull request may close this issue.

Fix/360 aiondemand/AIOD-rest-api
1 participant
@PGijsbers