-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📦 Cap Cython under Python 3.12+ below v3.1 #1412
📦 Cap Cython under Python 3.12+ below v3.1 #1412
Conversation
CodSpeed Performance ReportMerging #1412 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1412 +/- ##
==========================================
- Coverage 96.06% 96.06% -0.01%
==========================================
Files 31 31
Lines 5772 5770 -2
Branches 345 345
==========================================
- Hits 5545 5543 -2
Misses 201 201
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
88bad56
to
2e0c592
Compare
7f5b60c
to
ee03913
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's change or symlink this to a packaging
type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I don't follow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a packaging-focused change, not a runtime bug. It only affects people building from sdist or downstream packagers. Hence, it must show up in the packaging category of the changelog.
It is possible to either rename it to 1412.packaging.rst
or commit a symlink. With a symlink in place, Towncrier will show this note in two places (bugfixes and packaging). Although, I'm not entirely sure whether it needs to be marked as a bug. Having a note for the downstream packagers is much more important.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok.
Honestly I don't really care.
Let's rename a file extension without making a symlink
Heh, looks like the timeline protector cannot read towncrier config from |
The bot works correctly, the config discovery has been fixed long ago. You deleted the file, and so there's no change note in the PR. The proper fix is to actually add one. |
The effect of this is that the pre-release versions of Cython are no longer allowed to be automatically installed into the ephemeral build environment, implicitly. Closes aio-libs#1411. Co-Authored-By: ajsanchezsanz <3304408+ajsanchezsanz@users.noreply.github.com> Co-Authored-By: markgreene74 <18945890+markgreene74@users.noreply.github.com> Co-Authored-By: Sviatoslav Sydorenko <webknjaz@redhat.com>
c719a38
to
3ca3805
Compare
Aah, my oversight. Sorry. |
What do these changes do?
Use latest Cython stable version, avoiding using pre-release versions.
Why? There is some issue with Cython 3.1.0a1 that is making the tests to fail.
Are there changes in behavior for the user?
No
Related issue number
Fixes #1411
Checklist