Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📦 Cap Cython under Python 3.12+ below v3.1 #1412

Merged

Conversation

ajsanchezsanz
Copy link
Contributor

What do these changes do?

Use latest Cython stable version, avoiding using pre-release versions.
Why? There is some issue with Cython 3.1.0a1 that is making the tests to fail.

Are there changes in behavior for the user?

No

Related issue number

Fixes #1411

Checklist

  • I think the code is well written
  • Unit tests for the changes exist - N/A
  • Documentation reflects the changes -N/A

Copy link

codspeed-hq bot commented Nov 9, 2024

CodSpeed Performance Report

Merging #1412 will not alter performance

Comparing ajsanchezsanz:fix/pulling_stable_cython_version (3ca3805) with master (3fbc1f1)

Summary

✅ 83 untouched benchmarks

Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.06%. Comparing base (3fbc1f1) to head (3ca3805).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1412      +/-   ##
==========================================
- Coverage   96.06%   96.06%   -0.01%     
==========================================
  Files          31       31              
  Lines        5772     5770       -2     
  Branches      345      345              
==========================================
- Hits         5545     5543       -2     
  Misses        201      201              
  Partials       26       26              
Flag Coverage Δ
CI-GHA 96.06% <100.00%> (-0.01%) ⬇️
MyPy 48.66% <100.00%> (-0.02%) ⬇️
OS-Linux 99.55% <ø> (ø)
OS-Windows 99.62% <ø> (ø)
OS-macOS 99.30% <ø> (ø)
Py-3.10.11 99.28% <ø> (ø)
Py-3.10.15 99.51% <ø> (ø)
Py-3.11.10 99.51% <ø> (ø)
Py-3.11.9 99.28% <ø> (ø)
Py-3.12.7 99.51% <ø> (ø)
Py-3.13.0 99.51% <ø> (ø)
Py-3.9.13 99.23% <ø> (ø)
Py-3.9.20 99.47% <ø> (ø)
Py-pypy7.3.16 99.53% <ø> (ø)
Py-pypy7.3.17 99.55% <ø> (ø)
VM-macos-latest 99.30% <ø> (ø)
VM-ubuntu-latest 99.55% <ø> (ø)
VM-windows-latest 99.62% <ø> (ø)
pytest 99.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ajsanchezsanz ajsanchezsanz force-pushed the fix/pulling_stable_cython_version branch from 88bad56 to 2e0c592 Compare November 9, 2024 18:39
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 9, 2024
@ajsanchezsanz ajsanchezsanz force-pushed the fix/pulling_stable_cython_version branch from 7f5b60c to ee03913 Compare November 9, 2024 18:49
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change or symlink this to a packaging type.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I don't follow

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a packaging-focused change, not a runtime bug. It only affects people building from sdist or downstream packagers. Hence, it must show up in the packaging category of the changelog.

It is possible to either rename it to 1412.packaging.rst or commit a symlink. With a symlink in place, Towncrier will show this note in two places (bugfixes and packaging). Although, I'm not entirely sure whether it needs to be marked as a bug. Having a note for the downstream packagers is much more important.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.
Honestly I don't really care.
Let's rename a file extension without making a symlink

CHANGES/1412.bugfix.rst Outdated Show resolved Hide resolved
packaging/pep517_backend/_backend.py Outdated Show resolved Hide resolved
@webknjaz webknjaz self-assigned this Nov 14, 2024
@webknjaz webknjaz added the dependencies Pull requests that update a dependency file label Nov 14, 2024
@asvetlov
Copy link
Member

Heh, looks like the timeline protector cannot read towncrier config from ./towncrier.toml.
I'll skip the check.

@asvetlov asvetlov added the bot:chronographer:skip This PR does not need to include a change note label Nov 14, 2024
@webknjaz webknjaz removed bot:chronographer:skip This PR does not need to include a change note bot:chronographer:provided There is a change note present in this PR labels Nov 14, 2024
@webknjaz
Copy link
Member

webknjaz commented Nov 14, 2024

The bot works correctly, the config discovery has been fixed long ago. You deleted the file, and so there's no change note in the PR. The proper fix is to actually add one.

The effect of this is that the pre-release versions of Cython are no
longer allowed to be automatically installed into the ephemeral build
environment, implicitly.

Closes aio-libs#1411.

Co-Authored-By: ajsanchezsanz <3304408+ajsanchezsanz@users.noreply.github.com>
Co-Authored-By: markgreene74 <18945890+markgreene74@users.noreply.github.com>
Co-Authored-By: Sviatoslav Sydorenko <webknjaz@redhat.com>
@webknjaz webknjaz force-pushed the fix/pulling_stable_cython_version branch from c719a38 to 3ca3805 Compare November 14, 2024 17:44
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 14, 2024
@webknjaz webknjaz changed the title Using Cython stable version 📦 Cap Cython under Python 3.12+ below v3.1 Nov 14, 2024
@webknjaz webknjaz merged commit 42c6f32 into aio-libs:master Nov 14, 2024
44 of 46 checks passed
@asvetlov
Copy link
Member

Aah, my oversight. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR dependencies Pull requests that update a dependency file
Development

Successfully merging this pull request may close these issues.

Tests failing in a new environment with an exception (ValueError: chr() arg not in range(0x110000))
3 participants