Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typing bugs found by beartype #993

Merged
merged 1 commit into from
Mar 24, 2024
Merged

Fix typing bugs found by beartype #993

merged 1 commit into from
Mar 24, 2024

Conversation

ods
Copy link
Collaborator

@ods ods commented Mar 24, 2024

Try pytest-beartype, as suggested by @antonagestam . Only two bugs found so far, doesn't seem enough to add it to CI.

Copy link

codecov bot commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.45%. Comparing base (256ce17) to head (a4dc676).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #993   +/-   ##
=======================================
  Coverage   95.45%   95.45%           
=======================================
  Files         112      112           
  Lines       16706    16706           
  Branches     2673     2673           
=======================================
  Hits        15946    15946           
  Misses        479      479           
  Partials      281      281           
Flag Coverage Δ
cext 92.17% <100.00%> (ø)
integration 95.09% <100.00%> (ø)
purepy 94.91% <100.00%> (ø)
unit 46.41% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antonagestam
Copy link

Cool stuff, I hope it at least brings some confidence to the type hints 👍

@ods ods merged commit e43a738 into aio-libs:master Mar 24, 2024
31 checks passed
@ods ods deleted the fix-beartype branch March 24, 2024 18:51
@ods
Copy link
Collaborator Author

ods commented Mar 24, 2024

I hope it at least brings some confidence to the type hints 👍

Unfortunately it doesn't catch even simple and obvious bugs. So, I'd like to find another runtime checker.

@antonagestam
Copy link

@ods FWIW, there's also typeguard: https://github.com/agronholm/typeguard

@ods
Copy link
Collaborator Author

ods commented Mar 25, 2024

FWIW, there's also typeguard: https://github.com/agronholm/typeguard

Right, but the use is not as simple as "install and add command line option", as it is with beartype

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants