Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type annotation for AIOKafkaAdminClient.create_partitions #978

Merged
merged 4 commits into from
Feb 11, 2024
Merged

Fix type annotation for AIOKafkaAdminClient.create_partitions #978

merged 4 commits into from
Feb 11, 2024

Conversation

alm0ra
Copy link
Contributor

@alm0ra alm0ra commented Feb 11, 2024

Fixes #977

Changes

Fixes wrong typo in create_partitions() for the admin client

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder

@alm0ra alm0ra changed the title 977.bugfix Fix type annotation for AIOKafkaAdminClient.create_partitions Feb 11, 2024
@alm0ra
Copy link
Contributor Author

alm0ra commented Feb 11, 2024

@tvoinarovskyi @ods

there is no documentation provided for AIOKafkaAdminClient so there is nothing to update and changes
also for test, there is a test for this part test_admin that satisfy this change

aiokafka/admin/client.py Outdated Show resolved Hide resolved
alm0ra and others added 2 commits February 11, 2024 21:37
Co-authored-by: Denis Otkidach <denis.otkidach@gmail.com>
@alm0ra
Copy link
Contributor Author

alm0ra commented Feb 11, 2024

@ods All resolved i think it's ready

Copy link

codecov bot commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9166c96) 95.11% compared to head (6cb1375) 95.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #978      +/-   ##
==========================================
- Coverage   95.11%   95.10%   -0.02%     
==========================================
  Files         107      107              
  Lines       16412    16413       +1     
  Branches     2625     2625              
==========================================
- Hits        15611    15610       -1     
- Misses        522      523       +1     
- Partials      279      280       +1     
Flag Coverage Δ
cext 91.81% <100.00%> (-0.02%) ⬇️
integration 94.75% <100.00%> (+<0.01%) ⬆️
purepy 94.57% <100.00%> (-0.02%) ⬇️
unit 44.90% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ods ods merged commit bb15ecf into aio-libs:master Feb 11, 2024
30 of 31 checks passed
@ods ods mentioned this pull request Feb 17, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invalid Type AioKafkaAdminClient create_partitions
2 participants