Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test_max_poll_interval_ms #903

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

ods
Copy link
Collaborator

@ods ods commented Jul 1, 2023

Changes

Fixes flakiness of tests/test_consumer.py::TestConsumerIntegration::test_max_poll_interval_ms test:

        await listener1.assignment_ready.wait()
        await listener2.assignment_ready.wait()
>       self.assertTrue(consumer1.assignment())
E       AssertionError: set() is not true

tests/test_consumer.py:2024: AssertionError

@codecov
Copy link

codecov bot commented Jul 1, 2023

Codecov Report

Merging #903 (bdf014b) into master (5ce5649) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #903   +/-   ##
=======================================
  Coverage   97.59%   97.59%           
=======================================
  Files          30       30           
  Lines        5451     5451           
=======================================
  Hits         5320     5320           
  Misses        131      131           
Flag Coverage Δ
cext 88.44% <ø> (+0.03%) ⬆️
integration 97.56% <ø> (ø)
purepy 97.10% <ø> (-0.04%) ⬇️
unit 38.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ods ods merged commit 772aa75 into aio-libs:master Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant