handled other SASL mechanism in logging #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change is so small. So i didn't update changelog |
Please create Fixes #852. |
mangin
force-pushed
the
handle-other-sasl-mechanism-in-logging
branch
from
329c513
to
74f5ad5
Compare
Okay |
mangin
force-pushed
the
handle-other-sasl-mechanism-in-logging
branch
from
74f5ad5
to
c9478fc
Compare
Codecov Report
@@ Coverage Diff @@
## master #861 +/- ##
==========================================
- Coverage 97.55% 97.49% -0.07%
==========================================
Files 30 28 -2
Lines 5450 5389 -61
==========================================
- Hits 5317 5254 -63
- Misses 133 135 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@ods I think it's ready. if you have time can you take a look one more time? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles other sasl_mechanism into logging like:
'PLAIN', 'SCRAM-SHA-256', 'SCRAM-SHA-512'
Now we always write that we use PLAIN as auth sasl_mechanism.