Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation on how to install optional features (issue #645) #822

Merged
merged 3 commits into from
Feb 6, 2022

Conversation

ods
Copy link
Collaborator

@ods ods commented Feb 5, 2022

Changes

Fixes #645

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

@codecov
Copy link

codecov bot commented Feb 5, 2022

Codecov Report

Merging #822 (e2f7a4f) into master (ccbcc25) will decrease coverage by 0.53%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #822      +/-   ##
==========================================
- Coverage   97.49%   96.96%   -0.54%     
==========================================
  Files          30       30              
  Lines        5434     5434              
==========================================
- Hits         5298     5269      -29     
- Misses        136      165      +29     
Flag Coverage Δ
cext 87.74% <ø> (-0.58%) ⬇️
integration 96.92% <ø> (-0.54%) ⬇️
purepy 96.50% <ø> (-0.54%) ⬇️
unit 49.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiokafka/producer/sender.py 96.28% <0.00%> (-2.41%) ⬇️
aiokafka/client.py 96.64% <0.00%> (-1.53%) ⬇️
aiokafka/consumer/consumer.py 96.71% <0.00%> (-1.20%) ⬇️
aiokafka/producer/producer.py 97.56% <0.00%> (-0.98%) ⬇️
aiokafka/admin.py 87.38% <0.00%> (-0.94%) ⬇️
aiokafka/conn.py 93.23% <0.00%> (-0.44%) ⬇️
aiokafka/producer/message_accumulator.py 98.54% <0.00%> (-0.37%) ⬇️
aiokafka/consumer/fetcher.py 97.00% <0.00%> (-0.16%) ⬇️
aiokafka/consumer/group_coordinator.py 98.89% <0.00%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccbcc25...e2f7a4f. Read the comment docs.

@ods ods merged commit 2c54e10 into aio-libs:master Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Readme for lz4 compression use out-of-date
2 participants