Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Producer waitlist for pending send() items #814

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tvoinarovskyi
Copy link
Member

Changes

Fixes #528

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

@tvoinarovskyi tvoinarovskyi requested a review from ods January 3, 2022 10:15
@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #814 (0dcb78c) into master (ccbcc25) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #814      +/-   ##
==========================================
+ Coverage   97.49%   97.56%   +0.06%     
==========================================
  Files          30       30              
  Lines        5434     5452      +18     
==========================================
+ Hits         5298     5319      +21     
+ Misses        136      133       -3     
Flag Coverage Δ
cext 88.40% <100.00%> (+0.09%) ⬆️
integration 97.52% <100.00%> (+0.06%) ⬆️
purepy 97.10% <100.00%> (+0.06%) ⬆️
unit 49.74% <88.23%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiokafka/producer/message_accumulator.py 99.31% <100.00%> (+0.40%) ⬆️
aiokafka/producer/producer.py 98.53% <100.00%> (ø)
aiokafka/consumer/fetcher.py 97.48% <0.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccbcc25...0dcb78c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Producer] Performance drop when 'send' is called from multiple Futures
3 participants