Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for BPO-42130 #802

Merged
merged 1 commit into from
Dec 6, 2021
Merged

Workaround for BPO-42130 #802

merged 1 commit into from
Dec 6, 2021

Conversation

ods
Copy link
Collaborator

@ods ods commented Dec 5, 2021

Changes

Fixes the problem with asyncio.wait_for(). Python 3.9 is added to CI and project classifiers.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

@codecov
Copy link

codecov bot commented Dec 5, 2021

Codecov Report

Merging #802 (676e4fa) into master (444a1a7) will increase coverage by 0.00%.
The diff coverage is 96.29%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #802   +/-   ##
=======================================
  Coverage   97.96%   97.96%           
=======================================
  Files          31       31           
  Lines        5307     5309    +2     
=======================================
+ Hits         5199     5201    +2     
  Misses        108      108           
Flag Coverage Δ
cext 88.67% <96.29%> (+0.06%) ⬆️
integration 97.92% <96.29%> (+<0.01%) ⬆️
purepy 97.40% <96.29%> (-0.10%) ⬇️
unit 51.94% <59.25%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiokafka/consumer/fetcher.py 97.48% <94.11%> (-0.18%) ⬇️
aiokafka/conn.py 93.83% <100.00%> (+0.24%) ⬆️
aiokafka/util.py 97.95% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 444a1a7...676e4fa. Read the comment docs.

Copy link
Member

@tvoinarovskyi tvoinarovskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants