Don't pass loop explicitly in docs and examples #693
Conversation
Codecov Report
@@ Coverage Diff @@
## master #693 +/- ##
==========================================
- Coverage 97.95% 97.92% -0.04%
==========================================
Files 29 29
Lines 5193 5193
==========================================
- Hits 5087 5085 -2
- Misses 106 108 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ods
force-pushed
the
docs_examples_loop
branch
from
67db442
to
46abcf5
Compare
| loop.close() | ||
| if not task.cancelled(): | ||
| task.result() | ||
| asyncio.run(Benchmark(args).bench_simple()) |
There was a problem hiding this comment.
Did you try running the benchmark? I think I had a very specific reason for writing the code that way, but it may be related to issues on earlier versions of Python.
There was a problem hiding this comment.
Just have run them and I see no difference. Probably it was the reason with old versions of asyncio.
| loop.close() | ||
| if not task.cancelled(): | ||
| task.result() | ||
| asyncio.run(Benchmark(args).bench_simple()) |
Changes
@asyncio.coroutineandyield fromwithasync defandawaitAIOKafkaConsumer/AIOKafkaProducer, useasyncio.run()Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.