-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't pass loop explicitly in docs and examples #693
Conversation
Codecov Report
@@ Coverage Diff @@
## master #693 +/- ##
==========================================
- Coverage 97.95% 97.92% -0.04%
==========================================
Files 29 29
Lines 5193 5193
==========================================
- Hits 5087 5085 -2
- Misses 106 108 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
67db442
to
46abcf5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
loop.close() | ||
if not task.cancelled(): | ||
task.result() | ||
asyncio.run(Benchmark(args).bench_simple()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you try running the benchmark? I think I had a very specific reason for writing the code that way, but it may be related to issues on earlier versions of Python.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just have run them and I see no difference. Probably it was the reason with old versions of asyncio.
loop.close() | ||
if not task.cancelled(): | ||
task.result() | ||
asyncio.run(Benchmark(args).bench_simple()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
Changes
@asyncio.coroutine
andyield from
withasync def
andawait
AIOKafkaConsumer
/AIOKafkaProducer
, useasyncio.run()
Checklist
CHANGES
folder<issue_id>.<type>
(e.g.588.bugfix
)issue_id
change it to the pr id after creating the PR.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.