Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 1 #650

Merged
merged 2 commits into from
Oct 16, 2020
Merged

Patch 1 #650

merged 2 commits into from
Oct 16, 2020

Conversation

andreportela
Copy link
Contributor

closes #566

Changes

Fixes #566

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #650 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #650   +/-   ##
=======================================
  Coverage   47.77%   47.77%           
=======================================
  Files          29       29           
  Lines        5124     5124           
=======================================
  Hits         2448     2448           
  Misses       2676     2676           
Flag Coverage Δ
#cext 37.47% <ø> (ø)
#integration 47.73% <ø> (ø)
#purepy 47.28% <ø> (ø)
#unit 39.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiokafka/producer/producer.py 42.07% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84e2a98...1aa9088. Read the comment docs.

@tvoinarovskyi
Copy link
Member

Thanks!

@tvoinarovskyi tvoinarovskyi merged commit 5622e9b into aio-libs:master Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve documentation for Producer header support
2 participants