Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unintended cancellation of fetcher task #1007

Merged
merged 2 commits into from
May 12, 2024
Merged

Fix unintended cancellation of fetcher task #1007

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3091bc
Fix unintented cancellation of fetcher task
apmorton May 9, 2024
4c40f19
Update aiokafka/consumer/fetcher.py
apmorton May 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion aiokafka/consumer/fetcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,8 @@
# cancellation
if not task.done():
task.cancel()
await task
with contextlib.suppress(asyncio.CancelledError):
await task

Check warning on line 516 in aiokafka/consumer/fetcher.py

View check run for this annotation

Codecov / codecov/patch

aiokafka/consumer/fetcher.py#L516 

Added line #L516 was not covered by tests
ods marked this conversation as resolved.
Show resolved Hide resolved
self._pending_tasks.clear()
self._records.clear()

Expand Down
Loading