Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdist tarball (version 0.7.0) on pypi contains pre-compiled shared objects for python3.7 #681

Closed
toabctl opened this issue Nov 3, 2020 · 3 comments · Fixed by #684
Closed

Comments

@toabctl
Copy link

toabctl commented Nov 3, 2020

Describe the bug

When downloading https://files.pythonhosted.org/packages/19/a7/c8b9c764ca4cf3ce7e5f773716575622b368430922cb054eef5b6a257476/aiokafka-0.7.0.tar.gz and then looking at the content:

$ tar tfz aiokafka-0.7.0.tar.gz |grep .so
aiokafka-0.7.0/aiokafka/record/_crecords/cutil.cpython-37m-x86_64-linux-gnu.so
aiokafka-0.7.0/aiokafka/record/_crecords/default_records.cpython-37m-x86_64-linux-gnu.so
aiokafka-0.7.0/aiokafka/record/_crecords/legacy_records.cpython-37m-x86_64-linux-gnu.so
aiokafka-0.7.0/aiokafka/record/_crecords/memory_records.cpython-37m-x86_64-linux-gnu.so

Theses files should not be included in a source tarball. This is a problem when trying to package the sdist tarball eg. for python3.8 . In that case, RPMs autodetection of requirements would still require python3.7:

@ods
Copy link
Collaborator

ods commented Nov 4, 2020

Autogenerated by cython .c files shouldn't be included too?

@asvetlov
Copy link
Member

asvetlov commented Nov 5, 2020

Many libraries (aiohttp included) are shipped with pre-generated .c files. It allows building tarball without cython installed. I don't know how is the requirement important though.

ods added a commit to ods/aiokafka that referenced this issue Nov 13, 2020
ods added a commit to ods/aiokafka that referenced this issue Nov 13, 2020
@ods ods closed this as completed in #684 Nov 13, 2020
@toabctl
Copy link
Author

toabctl commented Nov 16, 2020

.c files should be included. I'm talking about compiled share objects. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants