remove timestamp/timestamp_type from cython DefaultRecord

aio-libs · Apr 25, 2024 · 9875343 · 9875343
1 parent e0d1b4b
commit 9875343
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 18 deletions.
diff --git a/aiokafka/record/_crecords/default_records.pyi b/aiokafka/record/_crecords/default_records.pyi
@@ -21,6 +21,8 @@ from aiokafka.record._types import (
 @final
 class DefaultRecord(DefaultRecordProtocol):
     offset: int
+    timestamp: int
+    timestamp_type: int
     key: bytes | None
     value: bytes | None
     headers: list[tuple[str, bytes | None]]
@@ -35,10 +37,6 @@ class DefaultRecord(DefaultRecordProtocol):
         value: bytes | None,
         headers: list[tuple[str, bytes | None]],
     ) -> None: ...
-    @property
-    def timestamp(self) -> int | None: ...
-    @property
-    def timestamp_type(self) -> int | None: ...
 
 @final
 class DefaultRecordBatch(DefaultRecordBatchProtocol):

diff --git a/aiokafka/record/_crecords/default_records.pyx b/aiokafka/record/_crecords/default_records.pyx
@@ -448,20 +448,6 @@ cdef class DefaultRecord:
         record.headers = headers
         return record
 
-    @property
-    def timestamp(self):
-        if self.timestamp != -1:
-            return self.timestamp
-        else:
-            return None
-
-    @property
-    def timestamp_type(self):
-        if self.timestamp != -1:
-            return self.timestamp_type
-        else:
-            return None
-
     def __repr__(self):
         return (
             "DefaultRecord(offset={!r}, timestamp={!r}, timestamp_type={!r},"