Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9997/8c36b51 backport][3.11] Restore the force_close method to the ResponseHandler #9998

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 19, 2024

(cherry picked from commit 8c36b51)

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 19, 2024
@bdraco bdraco changed the title Restore the force_close method to the ResponseHandler (#9997) [PR #9997/8c36b51 backport][3.11] Restore the force_close method to the ResponseHandler Nov 19, 2024
@bdraco bdraco enabled auto-merge (squash) November 19, 2024 18:36
Copy link

codspeed-hq bot commented Nov 19, 2024

CodSpeed Performance Report

Merging #9998 will not alter performance

Comparing patchback/backports/3.11/8c36b51e479bf2eec5ad71043c07232dc26d1582/pr-9997 (f7de3e7) with 3.11 (b235e76)

Summary

✅ 43 untouched benchmarks

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (3.11@81c33ec). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.11    #9998   +/-   ##
=======================================
  Coverage        ?   98.02%           
=======================================
  Files           ?      122           
  Lines           ?    36902           
  Branches        ?     4440           
=======================================
  Hits            ?    36175           
  Misses          ?      544           
  Partials        ?      183           
Flag Coverage Δ
CI-GHA 97.92% <100.00%> (?)
OS-Linux 97.62% <100.00%> (?)
OS-Windows 94.52% <100.00%> (?)
OS-macOS 96.73% <100.00%> (?)
Py-3.10.11 96.59% <100.00%> (?)
Py-3.10.15 97.13% <100.00%> (?)
Py-3.11.10 97.20% <100.00%> (?)
Py-3.11.9 96.67% <100.00%> (?)
Py-3.12.7 97.65% <100.00%> (?)
Py-3.13.0 97.68% <100.00%> (?)
Py-3.9.13 96.52% <100.00%> (?)
Py-3.9.20 97.09% <100.00%> (?)
Py-pypy7.3.16 96.66% <100.00%> (?)
VM-macos 96.73% <100.00%> (?)
VM-ubuntu 97.62% <100.00%> (?)
VM-windows 94.52% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit b7e3b30 into 3.11 Nov 19, 2024
33 of 34 checks passed
@bdraco bdraco deleted the patchback/backports/3.11/8c36b51e479bf2eec5ad71043c07232dc26d1582/pr-9997 branch November 19, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant