-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compressed get request benchmark payload length #9844
Conversation
The payload length was much smaller than expected because zlib more efficent than expected and previous testing to calculate the payload size was incorrect
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9844 +/- ##
==========================================
- Coverage 98.70% 98.70% -0.01%
==========================================
Files 118 118
Lines 36174 36172 -2
Branches 4297 4297
==========================================
- Hits 35706 35704 -2
Misses 315 315
Partials 153 153
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #9844 will improve performances by 8.21%Comparing Summary
Benchmarks breakdown
|
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #9845 🤖 @patchback |
(cherry picked from commit fabf388)
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #9846 🤖 @patchback |
(cherry picked from commit fabf388)
…rk payload length (#9845) Co-authored-by: J. Nick Koston <nick@koston.org>
…rk payload length (#9846) Co-authored-by: J. Nick Koston <nick@koston.org>
The payload length was much smaller than expected because zlib more efficient than expected and previous testing to calculate the payload size was incorrect