Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compressed get request benchmark payload length #9844

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 12, 2024

The payload length was much smaller than expected because zlib more efficient than expected and previous testing to calculate the payload size was incorrect

The payload length was much smaller than expected because zlib
more efficent than expected and previous testing to calculate
the payload size was incorrect
@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.10 backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Nov 12, 2024
@bdraco bdraco requested a review from asvetlov as a code owner November 12, 2024 21:32
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.70%. Comparing base (2b135a8) to head (945dede).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9844      +/-   ##
==========================================
- Coverage   98.70%   98.70%   -0.01%     
==========================================
  Files         118      118              
  Lines       36174    36172       -2     
  Branches     4297     4297              
==========================================
- Hits        35706    35704       -2     
  Misses        315      315              
  Partials      153      153              
Flag Coverage Δ
CI-GHA 98.59% <100.00%> (-0.01%) ⬇️
OS-Linux 98.28% <100.00%> (-0.01%) ⬇️
OS-Windows 96.07% <100.00%> (-0.01%) ⬇️
OS-macOS 97.36% <100.00%> (-0.01%) ⬇️
Py-3.10.11 97.20% <100.00%> (-0.01%) ⬇️
Py-3.10.15 97.81% <100.00%> (+0.05%) ⬆️
Py-3.11.10 97.81% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.26% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 98.35% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 98.33% <100.00%> (+0.05%) ⬆️
Py-3.9.13 97.13% <100.00%> (-0.01%) ⬇️
Py-3.9.20 97.72% <100.00%> (+0.05%) ⬆️
Py-pypy7.3.16 97.29% <100.00%> (-0.01%) ⬇️
VM-macos 97.36% <100.00%> (-0.01%) ⬇️
VM-ubuntu 98.28% <100.00%> (-0.01%) ⬇️
VM-windows 96.07% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as draft November 12, 2024 22:27
Copy link

codspeed-hq bot commented Nov 12, 2024

CodSpeed Performance Report

Merging #9844 will improve performances by 8.21%

Comparing compressed_get_request (945dede) with master (2b135a8)

Summary

⚡ 1 improvements
✅ 22 untouched benchmarks

🆕 1 new benchmarks
⁉️ 1 (👁 1) dropped benchmarks

Benchmarks breakdown

Benchmark master compressed_get_request Change
👁 test_five_get_requests_with_567296_compressed_chunked_payload[pyloop] 122 ms N/A N/A
🆕 test_get_request_with_251308_compressed_chunked_payload[pyloop] N/A 465.1 ms N/A
test_one_thousand_large_round_trip_websocket_text_messages[pyloop] 25.3 ms 23.4 ms +8.21%

@bdraco bdraco marked this pull request as ready for review November 12, 2024 22:47
@bdraco bdraco enabled auto-merge (squash) November 12, 2024 22:48
@bdraco bdraco merged commit fabf388 into master Nov 12, 2024
37 of 38 checks passed
@bdraco bdraco deleted the compressed_get_request branch November 12, 2024 22:52
Copy link
Contributor

patchback bot commented Nov 12, 2024

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/fabf3884d645ff923214293485f9c2204d03e0c2/pr-9844

Backported as #9845

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 12, 2024
Copy link
Contributor

patchback bot commented Nov 12, 2024

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/fabf3884d645ff923214293485f9c2204d03e0c2/pr-9844

Backported as #9846

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 12, 2024
bdraco added a commit that referenced this pull request Nov 13, 2024
…rk payload length (#9845)

Co-authored-by: J. Nick Koston <nick@koston.org>
bdraco added a commit that referenced this pull request Nov 13, 2024
…rk payload length (#9846)

Co-authored-by: J. Nick Koston <nick@koston.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant