Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9309/e4028333 backport][3.10] Fix building the URL in BaseRequest when the host contains a port or IPv6 address #9318

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Sep 27, 2024

This is a backport of PR #9309 as merged into master (e402833).

What do these changes do?

The port was incorrectly being passed in the host field to URL.build when the Host header included the port

Are there changes in behavior for the user?

Calling BaseRequest.url will not fail with yarl 1.13.0+ when the host header has a port

Is it a substantial burden for the maintainers to support this?

no

Related issue number

fixes #9307

@bdraco bdraco enabled auto-merge (squash) September 27, 2024 18:24
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.79%. Comparing base (d32d580) to head (b4df984).
Report is 1 commits behind head on 3.10.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.10    #9318   +/-   ##
=======================================
  Coverage   97.78%   97.79%           
=======================================
  Files         108      108           
  Lines       34837    34842    +5     
  Branches     4163     4163           
=======================================
+ Hits        34067    34072    +5     
  Misses        573      573           
  Partials      197      197           
Flag Coverage Δ
CI-GHA 97.68% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.36% <100.00%> (+<0.01%) ⬆️
OS-Windows 94.97% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.05% <100.00%> (-0.02%) ⬇️
Py-3.10.11 97.03% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 96.96% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 96.94% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.01% <100.00%> (+<0.01%) ⬆️
Py-3.12.6 97.41% <100.00%> (+<0.01%) ⬆️
Py-3.13.0-rc.2 97.39% <100.00%> (+<0.01%) ⬆️
Py-3.8.10 94.47% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 96.76% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.94% <100.00%> (-0.01%) ⬇️
Py-3.9.20 96.88% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 96.48% <100.00%> (+<0.01%) ⬆️
VM-macos 97.05% <100.00%> (-0.02%) ⬇️
VM-ubuntu 97.36% <100.00%> (+<0.01%) ⬆️
VM-windows 94.97% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco closed this Sep 27, 2024
auto-merge was automatically disabled September 27, 2024 18:39

Pull request was closed

@bdraco bdraco reopened this Sep 27, 2024
@bdraco bdraco enabled auto-merge (squash) September 27, 2024 18:59
@bdraco bdraco merged commit 8220ced into 3.10 Sep 27, 2024
39 of 70 checks passed
@bdraco bdraco deleted the patchback/backports/3.10/e40283338eab5b501e8e91e5b24c2c38cb1a0c71/pr-9309 branch September 27, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant