Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9301/c240b52 backport][3.10] Replace code that can now be handled by yarl #9314

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 27, 2024

(cherry picked from commit c240b52)

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.78%. Comparing base (fd5ece6) to head (40e245a).
Report is 1 commits behind head on 3.10.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
aiohttp/client_reqrep.py 87.50% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             3.10    #9314   +/-   ##
=======================================
  Coverage   97.78%   97.78%           
=======================================
  Files         108      108           
  Lines       34828    34837    +9     
  Branches     4158     4163    +5     
=======================================
+ Hits        34058    34067    +9     
  Misses        573      573           
  Partials      197      197           
Flag Coverage Δ
CI-GHA 97.68% <92.85%> (+<0.01%) ⬆️
OS-Linux 97.36% <92.85%> (+<0.01%) ⬆️
OS-Windows 94.97% <92.85%> (+<0.01%) ⬆️
OS-macOS 97.06% <92.85%> (+<0.01%) ⬆️
Py-3.10.11 97.02% <64.28%> (-0.02%) ⬇️
Py-3.10.15 96.96% <64.28%> (-0.02%) ⬇️
Py-3.11.10 96.94% <92.85%> (+<0.01%) ⬆️
Py-3.11.9 97.01% <92.85%> (+<0.01%) ⬆️
Py-3.12.6 97.41% <92.85%> (+<0.01%) ⬆️
Py-3.13.0-rc.2 97.39% <92.85%> (+<0.01%) ⬆️
Py-3.8.10 94.47% <64.28%> (-0.02%) ⬇️
Py-3.8.18 96.76% <64.28%> (-0.02%) ⬇️
Py-3.9.13 96.94% <64.28%> (-0.02%) ⬇️
Py-3.9.20 96.88% <64.28%> (-0.02%) ⬇️
Py-pypy7.3.16 96.48% <64.28%> (-0.02%) ⬇️
VM-macos 97.06% <92.85%> (+<0.01%) ⬆️
VM-ubuntu 97.36% <92.85%> (+<0.01%) ⬆️
VM-windows 94.97% <92.85%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco changed the title Replace code that can now be handled by yarl (#9301) [PR #9301/c240b52 backport][3.10] Replace code that can now be handled by yarl Sep 27, 2024
@bdraco bdraco enabled auto-merge (squash) September 27, 2024 17:33
@bdraco bdraco merged commit d32d580 into 3.10 Sep 27, 2024
34 of 36 checks passed
@bdraco bdraco deleted the patchback/backports/3.10/c240b52de0505759aa13f2870feb7380d3b50a56/pr-9301 branch September 27, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant