Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9172/b93ef57c backport][3.10] Improve performance of starting web requests when content length is not set #9192

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Sep 18, 2024

This is a backport of PR #9172 as merged into master (b93ef57).

What do these changes do?

Reorder the start logic to avoid the check to remove content length if its not present

Are there changes in behavior for the user?

no

Is it a substantial burden for the maintainers to support this?

no

related issue #2779

before
start_before

after
start_after

@bdraco bdraco enabled auto-merge (squash) September 18, 2024 16:02
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.78%. Comparing base (2770e61) to head (ea9be10).
Report is 1 commits behind head on 3.10.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.10    #9192   +/-   ##
=======================================
  Coverage   97.78%   97.78%           
=======================================
  Files         108      108           
  Lines       34558    34569   +11     
  Branches     4126     4126           
=======================================
+ Hits        33792    33805   +13     
+ Misses        572      571    -1     
+ Partials      194      193    -1     
Flag Coverage Δ
CI-GHA 97.68% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.36% <100.00%> (+<0.01%) ⬆️
OS-Windows 94.94% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.05% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.14% <100.00%> (+<0.01%) ⬆️
Py-3.10.14 97.07% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.30% <100.00%> (+<0.01%) ⬆️
Py-3.12.5 97.00% <100.00%> (+0.11%) ⬆️
Py-3.12.6 97.40% <100.00%> (+0.08%) ⬆️
Py-3.8.10 94.56% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 96.86% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.04% <100.00%> (+<0.01%) ⬆️
Py-3.9.19 96.98% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 96.58% <100.00%> (+<0.01%) ⬆️
VM-macos 97.05% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.36% <100.00%> (+<0.01%) ⬆️
VM-windows 94.94% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit c717b25 into 3.10 Sep 18, 2024
31 of 32 checks passed
@bdraco bdraco deleted the patchback/backports/3.10/b93ef57cce9ea95954d17b7e4ca11883a4da2471/pr-9172 branch September 18, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant