Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9173/d3c3c6a7 backport][3.11] Avoid calling response prepare hook if its empty #9189

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Sep 18, 2024

This is a backport of PR #9173 as merged into master (d3c3c6a).

What do these changes do?

Avoid calling response prepare hook if its empty as its likely to be empty in most cases

Are there changes in behavior for the user?

no

Is it a substantial burden for the maintainers to support this?

no

related issue #2779

before
prepare_hook_before

after
prepare_hook_after

@bdraco bdraco enabled auto-merge (squash) September 18, 2024 13:24
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.78%. Comparing base (a24d690) to head (65225c6).
Report is 2 commits behind head on 3.11.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.11    #9189   +/-   ##
=======================================
  Coverage   97.78%   97.78%           
=======================================
  Files         108      108           
  Lines       34645    34646    +1     
  Branches     4123     4124    +1     
=======================================
+ Hits        33878    33879    +1     
  Misses        573      573           
  Partials      194      194           
Flag Coverage Δ
CI-GHA 97.68% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.36% <100.00%> (-0.01%) ⬇️
OS-Windows 94.94% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.06% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.14% <100.00%> (+<0.01%) ⬆️
Py-3.10.14 97.08% <100.00%> (+0.18%) ⬆️
Py-3.10.15 ?
Py-3.11.10 96.98% <100.00%> (?)
Py-3.11.9 97.04% <100.00%> (-0.26%) ⬇️
Py-3.12.5 97.08% <100.00%> (-0.01%) ⬇️
Py-3.12.6 97.14% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.04% <100.00%> (-0.01%) ⬇️
Py-3.9.19 96.99% <100.00%> (+0.07%) ⬆️
Py-3.9.20 ?
Py-pypy7.3.16 96.58% <100.00%> (-0.01%) ⬇️
VM-macos 97.06% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.36% <100.00%> (-0.01%) ⬇️
VM-windows 94.94% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 45dd34c into 3.11 Sep 18, 2024
27 of 28 checks passed
@bdraco bdraco deleted the patchback/backports/3.11/d3c3c6a7fd752450554ccbbcf875cc17740ceaa2/pr-9173 branch September 18, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant