-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make MESSAGE_TYPES_WITH_CONTENT a frozenset for the WebSocketReader #8747
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8747 +/- ##
=======================================
Coverage 98.13% 98.14%
=======================================
Files 107 107
Lines 34067 34067
Branches 4030 4030
=======================================
+ Hits 33433 33435 +2
+ Misses 457 456 -1
+ Partials 177 176 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #8750 🤖 @patchback |
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #8751 🤖 @patchback |
…frozenset for the WebSocketReader (#8750) Co-authored-by: J. Nick Koston <nick@koston.org>
…frozenset for the WebSocketReader (#8751) Co-authored-by: J. Nick Koston <nick@koston.org>
followup #8736 (comment)
frozenset is a tiny bit faster than the tuple
0.013342750000447268 vs 0.018335040998863406