Improve performance of generating random WebSocket mask #8667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mask was being generated with randint and than converted to bytes. We can skip a few steps and generate it with getrandbits() and pack it into bytes.
bdraco
added
backport-3.10
backport-3.11
bdraco
commented
Aug 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8667 +/- ##
=======================================
Coverage 97.97% 97.97%
=======================================
Files 107 107
Lines 33790 33791 +1
Branches 3969 3969
=======================================
+ Hits 33106 33107 +1
Misses 507 507
Partials 177 177
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bdraco
commented
Aug 9, 2024
psf-chronographer
bot
added
the
bot:chronographer:provided
Dreamsorcerer
approved these changes
Aug 9, 2024
|
thanks |
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #8668 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Aug 9, 2024
(cherry picked from commit 406cd2c)
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #8669 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Aug 9, 2024
(cherry picked from commit 406cd2c)
bdraco
added a commit
that referenced
this pull request
Aug 9, 2024
…random WebSocket mask (#8668) Co-authored-by: J. Nick Koston <nick@koston.org>
bdraco
added a commit
that referenced
this pull request
Aug 9, 2024
…random WebSocket mask (#8669) Co-authored-by: J. Nick Koston <nick@koston.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The mask was being generated with randint and than converted to bytes. We can skip a few steps and generate it with getrandbits() and pack it into bytes.
related RFC: https://datatracker.ietf.org/doc/html/rfc6455#section-5.3
Are there changes in behavior for the user?
No
Is it a substantial burden for the maintainers to support this?
no
I was looking at pings and noticed that most of the time is spent in randrange
