[PR #8558/e48acaf7 backport][3.10] Add followup changelog message for #5278 #8576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.10 #8576 +/- ##
=======================================
Coverage 97.57% 97.57%
=======================================
Files 108 108
Lines 33634 33634
Branches 4034 4034
=======================================
Hits 32819 32819
Misses 594 594
Partials 221 221
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bdraco
deleted the
patchback/backports/3.10/e48acaf7dd689dfb8f8f424257e463fdd0cec86a/pr-8558
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #8558 as merged into master (e48acaf).
closes #8555
What do these changes do?
Improve the changelog documentation for #5278
#5278 removed the deprecation warning about having a running event loop and replaced it with
asyncio.get_running_loop()which will raiseRuntimeErrorif there is no running loop.Since the deprecation was done in #3372, which first appeared in https://github.com/aio-libs/aiohttp/releases/tag/v3.5.0 (~5 years, 7 months ago), reverting and extending the deprecation period did not seem warranted as five years should be enough notice.