Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #8445 backport][3.9] Fixes read_timeout on WS connection not respecting ws_connect's timeouts #8444 #8446

Closed
wants to merge 1 commit into from

Conversation

arcivanov
Copy link
Contributor

Please see #8445 for the source PR

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jun 7, 2024
@bdraco
Copy link
Member

bdraco commented Jun 7, 2024

The bot will auto-create backport PRs (assuming there are no conflicts) from #8445 once it merges since its tagged with the backport tags.

@arcivanov
Copy link
Contributor Author

arcivanov commented Jun 8, 2024

@bdraco there will be major conflicts as the API changed (ClientWSTimeout introduced in master vs 3.9)

Copy link

codecov bot commented Jun 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.42%. Comparing base (e4a63ff) to head (db19243).
Report is 2 commits behind head on 3.9.

Additional details and impacted files
@@            Coverage Diff             @@
##              3.9    #8446      +/-   ##
==========================================
- Coverage   97.43%   97.42%   -0.02%     
==========================================
  Files         108      108              
  Lines       32884    32955      +71     
  Branches     3908     3915       +7     
==========================================
+ Hits        32042    32105      +63     
- Misses        633      639       +6     
- Partials      209      211       +2     
Flag Coverage Δ
CI-GHA 97.33% <100.00%> (-0.02%) ⬇️
OS-Linux 97.03% <100.00%> (+<0.01%) ⬆️
OS-Windows 94.59% <100.00%> (+0.01%) ⬆️
OS-macOS ?
Py-3.10.11 94.41% <100.00%> (+0.01%) ⬆️
Py-3.10.14 96.78% <100.00%> (-0.03%) ⬇️
Py-3.11.9 97.04% <100.00%> (-0.02%) ⬇️
Py-3.12.3 97.09% <100.00%> (-0.02%) ⬇️
Py-3.8.10 94.38% <100.00%> (+0.01%) ⬆️
Py-3.8.18 96.75% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 94.39% <100.00%> (+<0.01%) ⬆️
Py-3.9.19 96.77% <100.00%> (-0.03%) ⬇️
Py-pypy7.3.15 ?
Py-pypy7.3.16 96.33% <100.00%> (?)
VM-macos ?
VM-ubuntu 97.03% <100.00%> (+<0.01%) ⬆️
VM-windows 94.59% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco changed the title Backport: #8444 into 3.9 Fixes read_timeout on WS connection not respecting ws_connect's timeouts #8444 Jun 8, 2024
@Dreamsorcerer
Copy link
Member

@bdraco there will be major conflicts as the API changed (ClientWSTimeout introduced in master vs 3.9)

Yes, but it's preferable to follow our normal backport procedure to ensure everything lines up with cherry picking etc. (for example, this needs to backport to 3.10 first).

Please see aio-libs#8445 for the source PR
@bdraco bdraco changed the title Fixes read_timeout on WS connection not respecting ws_connect's timeouts #8444 [PR #8445 backport][3.9] Fixes read_timeout on WS connection not respecting ws_connect's timeouts #8444 Jun 8, 2024
@bdraco
Copy link
Member

bdraco commented Jul 17, 2024

3.9 is no longer getting backports. I'm going to close this one since we are going to do a 3.10 release soon

@bdraco bdraco closed this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants