Remove use of typing.ByteString
#8408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if this needs a changelog entry since the first Python 3.14 alpha version has yet to be released. But happy to add one if necessary. I suppose it fixes a DeprecationWarning on Python 3.12 and 3.13 as well. |
Dreamsorcerer
added
bot:chronographer:skip
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8408 +/- ##
=======================================
Coverage 97.64% 97.64%
=======================================
Files 107 107
Lines 33067 33067
Branches 3885 3885
=======================================
Hits 32288 32288
Misses 562 562
Partials 217 217
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
We error on warnings, so I don't think there's a warning being produced currently. |
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #8409 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
May 10, 2024
(cherry picked from commit 17c3971)
5 tasks
Dreamsorcerer
pushed a commit
that referenced
this pull request
May 10, 2024
…8409) **This is a backport of PR #8408 as merged into master (17c3971).** ## What do these changes do? This PR removes use of `typing.ByteString` from `aiohttp`. `ByteString` has been deprecated since Python 3.12, and has already been removed on the CPython `main` branch (though that change will not be released until Python 3.14 comes out). That means that `aiohttp` currently installs, but fails to be imported, on Python 3.14: ```pytb import aiohttp env/lib/python3.14/site-packages/aiohttp/__init__.py:6: in <module> from .client import ( env/lib/python3.14/site-packages/aiohttp/client.py:38: in <module> from . import hdrs, http, payload env/lib/python3.14/site-packages/aiohttp/payload.py:10: in <module> from typing import ( E ImportError: cannot import name 'ByteString' from 'typing' (/Users/alexw/dev/cpython/Lib/typing.py) ``` ## Are there changes in behavior for the user? The user will now be able to import `aiohttp` using Python 3.14+ ## Is it a substantial burden for the maintainers to support this? no ## Checklist - [x] I think the code is well written - [ ] Unit tests for the changes exist - [ ] Documentation reflects the changes - [ ] If you provide code modification, please add yourself to `CONTRIBUTORS.txt` * The format is <Name> <Surname>. * Please keep alphabetical order, the file is sorted by names. - [ ] Add a new news fragment into the `CHANGES/` folder * name it `<issue_or_pr_num>.<type>.rst` (e.g. `588.bugfix.rst`) * if you don't have an issue number, change it to the pull request number after creating the PR * `.bugfix`: A bug fix for something the maintainers deemed an improper undesired behavior that got corrected to match pre-agreed expectations. * `.feature`: A new behavior, public APIs. That sort of stuff. * `.deprecation`: A declaration of future API removals and breaking changes in behavior. * `.breaking`: When something public is removed in a breaking way. Could be deprecated in an earlier release. * `.doc`: Notable updates to the documentation structure or build process. * `.packaging`: Notes for downstreams about unobvious side effects and tooling. Changes in the test invocation considerations and runtime assumptions. * `.contrib`: Stuff that affects the contributor experience. e.g. Running tests, building the docs, setting up the development environment. * `.misc`: Changes that are hard to assign to any of the above categories. * Make sure to use full sentences with correct case and punctuation, for example: ```rst Fixed issue with non-ascii contents in doctest text files -- by :user:`contributor-gh-handle`. ``` Use the past tense or the present tense a non-imperative mood, referring to what's changed compared to the last released version of this project. Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR removes use of
typing.ByteStringfromaiohttp.ByteStringhas been deprecated since Python 3.12, and has already been removed on the CPythonmainbranch (though that change will not be released until Python 3.14 comes out). That means thataiohttpcurrently installs, but fails to be imported, on Python 3.14:Are there changes in behavior for the user?
The user will now be able to import
aiohttpusing Python 3.14+Is it a substantial burden for the maintainers to support this?
no
Checklist
CONTRIBUTORS.txtCHANGES/foldername it
<issue_or_pr_num>.<type>.rst(e.g.588.bugfix.rst)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature: A new behavior, public APIs. That sort of stuff..deprecation: A declaration of future API removals and breakingchanges in behavior.
.breaking: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc: Notable updates to the documentation structure or buildprocess.
.packaging: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.