Backport 3.9: Add tests, accidentally dropped before (#8088) #8372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 0016004)
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.9 #8372 +/- ##
==========================================
+ Coverage 97.39% 97.43% +0.04%
==========================================
Files 108 108
Lines 32877 32884 +7
Branches 3905 3908 +3
==========================================
+ Hits 32021 32042 +21
+ Misses 645 633 -12
+ Partials 211 209 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@pajod Did we already backport to 3.10? |
|
@Dreamsorcerer For 3.10 you merged #8141 - does not look quite the same because that was before #8297 - but this 3.9 PR is much later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picked from commit 0016004 (#8088)
Better late than never (3.10 backport in #8141) - but since its submitted after #8146 out of 4 tests to be conditionally re-enabled 2 are already unconditionally re-enabled.