-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete size arg from StreamReader.feed_data #7265 #8367
Conversation
for more information, see https://pre-commit.ci
Co-authored-by: Sam Bull <aa6bs0@sambull.org>
Co-authored-by: Sam Bull <aa6bs0@sambull.org>
Co-authored-by: Sam Bull <aa6bs0@sambull.org>
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8367 +/- ##
==========================================
- Coverage 97.61% 97.61% -0.01%
==========================================
Files 107 107
Lines 33092 33085 -7
Branches 3887 3875 -12
==========================================
- Hits 32303 32296 -7
Misses 572 572
Partials 217 217
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@DavidRomanovizc Thanks for getting through that, turned out to be quite tricky in the end. If you're interested in picking up any other tasks, there should be plenty of easier ones that should be quick to review. |
Finally completing the review for #7265.
Have added a small fix and now I think this is correct. Will double check it tomorrow before merging.