Allow to pass None as a timeout value to disable timeout logic

[alexkey]

What these changes does?

Allows to pass None as a timeout value to disable timeout logic.

In some cases there is needed to disable timeout logic but keep it in convenient code structure without ugly if-branching like this:

if delay:
    with aiohttp.Timeout(delay):
        async with session.get(url) as response:
            pass  # ...
else:
    async with session.get(url) as response:
        pass  # ...

Now it is able to use the same code for both numerical and None timeout values:

for delay in [None, 0, 0.1, 1]:
    with aiohttp.Timeout(delay):
        async with session.get(url) as response:
            pass  # ...

This behaviour is similar to asyncio.wait_for(fut, timeout, *, loop=None) coroutine, which takes None as a timeout value to block until the future completes.

How to test your changes?

There is a test in test_timeout.py: test_timeout_disable.

Related issue number

None.

Checklist

• Code is written and well
• Tests for the changes are provided
• Documentation reflects the changes

[coveralls]

Coverage increased (+0.0006%) to 98.264% when pulling 06e0e52 on alexkey:disable_timeout_with_none into a1f39a9 on KeepSafe:master.

[coveralls]

Coverage increased (+0.0006%) to 98.264% when pulling 6b61832 on alexkey:disable_timeout_with_none into a1f39a9 on KeepSafe:master.

[asvetlov]

Thanks!

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.