Patchback/backports/3.10/5fd29467fb63efdfae1ace280cec36b1f8139567/pr 8290

[NewGlad]

What do these changes do?

Backport of #8290 for 3.10

Are there changes in behavior for the user?

Is it a substantial burden for the maintainers to support this?

Related issue number

Checklist

• I think the code is well written
• Unit tests for the changes exist
• Documentation reflects the changes
• If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • The format is <Name> <Surname>.
  • Please keep alphabetical order, the file is sorted by names.
• Add a new news fragment into the CHANGES/ folder

  • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

  • if you don't have an issue number, change it to the pull request
    number after creating the PR

    • .bugfix: A bug fix for something the maintainers deemed an
      improper undesired behavior that got corrected to match
      pre-agreed expectations.
    • .feature: A new behavior, public APIs. That sort of stuff.
    • .deprecation: A declaration of future API removals and breaking
      changes in behavior.
    • .breaking: When something public is removed in a breaking way.
      Could be deprecated in an earlier release.
    • .doc: Notable updates to the documentation structure or build
      process.
    • .packaging: Notes for downstreams about unobvious side effects
      and tooling. Changes in the test invocation considerations and
      runtime assumptions.
    • .contrib: Stuff that affects the contributor experience. e.g.
      Running tests, building the docs, setting up the development
      environment.
    • .misc: Changes that are hard to assign to any of the above
      categories.

  • Make sure to use full sentences with correct case and punctuation,
    for example:

    Fixed issue with non-ascii contents in doctest text files
    -- by :user:`contributor-gh-handle`.

    Use the past tense or the present tense a non-imperative mood,
    referring to what's changed compared to the last released version
    of this project.

[NewGlad]

No need to patch anything in 3.10, will port the test only @Dreamsorcerer

[Dreamsorcerer]

No need to patch anything in 3.10, will port the test only @Dreamsorcerer

Surely the check still needs to be moved?

aiohttp/aiohttp/client.py

Lines 309 to 313 in 6392df7

	if not isinstance(timeout, ClientTimeout):
	raise ValueError(
	f"timeout parameter cannot be of {type(timeout)} type, "
	"please use 'timeout=ClientTimeout(...)'",
	)

If there wasn't an issue in 3.x, I don't see why the bug report would have been raised.

[NewGlad]

@Dreamsorcerer yes you are right, the issue now in the test - it does not fail if warning has been raised. I prefer to use my original variant then - it fails on raised warning.