-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust import timings test for python 3.12 #8260
Conversation
3.12 is expected to be a bit slower because of trade-offs that favor run-time performance over import time performance
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8260 +/- ##
=======================================
Coverage 97.56% 97.56%
=======================================
Files 107 107
Lines 32936 32938 +2
Branches 3851 3851
=======================================
+ Hits 32133 32135 +2
Misses 602 602
Partials 201 201
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.9: 💚 backport PR created✅ Backport PR branch: Backported as #8265 🤖 @patchback |
(cherry picked from commit 2434bfe)
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #8266 🤖 @patchback |
(cherry picked from commit 2434bfe)
…on 3.12 (#8265) Co-authored-by: J. Nick Koston <nick@koston.org>
…hon 3.12 (#8266) Co-authored-by: J. Nick Koston <nick@koston.org>
What do these changes do?
3.12 is expected to be a bit slower because of trade-offs that favor run-time performance over import time performance
Are there changes in behavior for the user?
no
Is it a substantial burden for the maintainers to support this?
no
Related issue number
Checklist
CONTRIBUTORS.txt
CHANGES/
foldername it
<issue_or_pr_num>.<type>.rst
(e.g.588.bugfix.rst
)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix
: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature
: A new behavior, public APIs. That sort of stuff..deprecation
: A declaration of future API removals and breakingchanges in behavior.
.breaking
: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc
: Notable updates to the documentation structure or buildprocess.
.packaging
: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib
: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc
: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.