Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust import timings test for python 3.12 #8260

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Mar 28, 2024

What do these changes do?

3.12 is expected to be a bit slower because of trade-offs that favor run-time performance over import time performance

Are there changes in behavior for the user?

no

Is it a substantial burden for the maintainers to support this?

no

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request
      number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an
        improper undesired behavior that got corrected to match
        pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking
        changes in behavior.
      • .breaking: When something public is removed in a breaking way.
        Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build
        process.
      • .packaging: Notes for downstreams about unobvious side effects
        and tooling. Changes in the test invocation considerations and
        runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g.
        Running tests, building the docs, setting up the development
        environment.
      • .misc: Changes that are hard to assign to any of the above
        categories.
    • Make sure to use full sentences with correct case and punctuation,
      for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.

      Use the past tense or the present tense a non-imperative mood,
      referring to what's changed compared to the last released version
      of this project.

3.12 is expected to be a bit slower because of trade-offs that
favor run-time performance over import time performance
@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.9 backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot labels Mar 28, 2024
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.56%. Comparing base (6ec4747) to head (f660d19).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8260   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files         107      107           
  Lines       32936    32938    +2     
  Branches     3851     3851           
=======================================
+ Hits        32133    32135    +2     
  Misses        602      602           
  Partials      201      201           
Flag Coverage Δ
CI-GHA 97.47% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.14% <100.00%> (+<0.01%) ⬆️
OS-Windows 95.81% <33.33%> (-0.01%) ⬇️
OS-macOS 96.95% <33.33%> (+<0.01%) ⬆️
Py-3.10.11 95.55% <33.33%> (-0.01%) ⬇️
Py-3.10.13 96.69% <33.33%> (-0.01%) ⬇️
Py-3.10.14 96.91% <100.00%> (+<0.01%) ⬆️
Py-3.11.8 96.92% <100.00%> (+<0.01%) ⬆️
Py-3.12.2 97.05% <100.00%> (+<0.01%) ⬆️
Py-3.8.10 95.52% <33.33%> (-0.01%) ⬇️
Py-3.8.18 96.88% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 95.52% <33.33%> (-0.01%) ⬇️
Py-3.9.18 96.66% <33.33%> (-0.01%) ⬇️
Py-3.9.19 96.88% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.15 96.45% <33.33%> (-0.01%) ⬇️
VM-macos 96.95% <33.33%> (+<0.01%) ⬆️
VM-ubuntu 97.14% <100.00%> (+<0.01%) ⬆️
VM-windows 95.81% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review March 28, 2024 21:55
@bdraco bdraco requested a review from asvetlov as a code owner March 28, 2024 21:55
@bdraco bdraco merged commit 2434bfe into master Mar 29, 2024
34 checks passed
@bdraco bdraco deleted the no_cover_import_test branch March 29, 2024 22:58
Copy link
Contributor

patchback bot commented Mar 29, 2024

Backport to 3.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.9/2434bfe855be75fc6cd156488d37d3971a8a320b/pr-8260

Backported as #8265

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 29, 2024
Copy link
Contributor

patchback bot commented Mar 29, 2024

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/2434bfe855be75fc6cd156488d37d3971a8a320b/pr-8260

Backported as #8266

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 29, 2024
bdraco added a commit that referenced this pull request Mar 29, 2024
…on 3.12 (#8265)

Co-authored-by: J. Nick Koston <nick@koston.org>
bdraco added a commit that referenced this pull request Mar 29, 2024
…hon 3.12 (#8266)

Co-authored-by: J. Nick Koston <nick@koston.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant