-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure websocket transport is closed when client does not close it (#8200) #8257
Ensure websocket transport is closed when client does not close it (#8200) #8257
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.10 #8257 +/- ##
==========================================
+ Coverage 97.46% 97.49% +0.03%
==========================================
Files 108 108
Lines 33038 33130 +92
Branches 3954 3954
==========================================
+ Hits 32200 32300 +100
+ Misses 635 627 -8
Partials 203 203
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nevermind, its running isolated. Its a regression in cpython 3.12 taking longer to import |
I was going to mark it |
Do we reckon it'll get improved in a future release? |
Can do, or we can skip it on 3.12 for now, if we think it's a temporary regression. |
It might be better in 3.13, but from what I gather the timing changes are expected in 3.12 as there were trade-offs to make other things at run time faster |
some more backstory python/cpython#90081 (but there is far more at play) |
Well, if coverage is going to affect the performance, we should disable it. That test will have no impact on coverage anyway as it does nothing more than import the library. If that makes a notable difference, then we may want to lower the threshold to match the new timings. If there is a regression in 3.12 we should probably just skip the test on 3.12. If there's still an issue on 3.13, then we can reevaluate. |
…fb66f4419d124a37fcc71/pr-8200
(cherry picked from commit 6ec4747)