-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix base_url param documentation #8197
fix base_url param documentation #8197
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8197 +/- ##
=======================================
Coverage 97.53% 97.53%
=======================================
Files 107 107
Lines 32843 32843
Branches 3851 3851
=======================================
Hits 32032 32032
Misses 610 610
Partials 201 201
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.9: 💚 backport PR created✅ Backport PR branch: Backported as #8198 🤖 @patchback |
(cherry picked from commit 0e91eb0)
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #8199 🤖 @patchback |
(cherry picked from commit 0e91eb0)
What do these changes do?
This PR update the documentation made in 38ffe6f to notify about a behavior introduce in 527b1b9
base_url
must not include path, otherwise an AssertionError is raisedAre there changes in behavior for the user?
No changes in behavior for the user since this is a documentation update
Is it a substantial burden for the maintainers to support this?
No
Checklist
CONTRIBUTORS.txt
CHANGES/
folder