Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix backwards compatibility with ssl #8098

Merged
merged 6 commits into from
Jan 29, 2024
Merged

Fix backwards compatibility with ssl #8098

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
11025b6
Fix backwards compatibility with ssl
Dreamsorcerer Jan 29, 2024
3b5c80c
Create 8098.bugfix.rst
Dreamsorcerer Jan 29, 2024
97649f6
Update CHANGES/8098.bugfix.rst
Dreamsorcerer Jan 29, 2024
6131848
Symlink
Dreamsorcerer Jan 29, 2024
2109880
Update 8098.bugfix.rst
Dreamsorcerer Jan 29, 2024
5a2d448
Test
Dreamsorcerer Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES/8098.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed backwards compatibility breakage of ``ssl`` parameter in some situations. -- by :user:`Dreamsorcerer`.
Dreamsorcerer marked this conversation as resolved.
Show resolved Hide resolved
Dreamsorcerer marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 2 additions & 0 deletions aiohttp/client_reqrep.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,8 @@ def _merge_ssl_params(
ssl_context: Optional["SSLContext"],
fingerprint: Optional[bytes],
) -> Union["SSLContext", bool, Fingerprint]:
if ssl is None:
ssl = True # Double check for backwards compatibility
if verify_ssl is not None and not verify_ssl:
warnings.warn(
"verify_ssl is deprecated, use ssl=False instead",
Expand Down
Loading