Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #8033/5424c534 backport][3.9] Small cleanups to WebSocketWriter #8036

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Jan 19, 2024

This is a backport of PR #8033 as merged into master (5424c53).

What do these changes do?

  • Add missing typing for random
  • Avoid duplicate len() calls

Are there changes in behavior for the user?

no

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (41968f8) 97.39% compared to head (0099136) 97.39%.
Report is 1 commits behind head on 3.9.

Additional details and impacted files
@@           Coverage Diff           @@
##              3.9    #8036   +/-   ##
=======================================
  Coverage   97.39%   97.39%           
=======================================
  Files         108      108           
  Lines       32496    32496           
  Branches     3848     3848           
=======================================
  Hits        31648    31648           
  Misses        646      646           
  Partials      202      202           
Flag Coverage Δ
CI-GHA 97.30% <100.00%> (ø)
OS-Linux 96.99% <100.00%> (ø)
OS-Windows 94.48% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.61% <100.00%> (-0.20%) ⬇️
Py-3.10.11 94.37% <100.00%> (ø)
Py-3.10.13 96.77% <100.00%> (ø)
Py-3.11.7 96.50% <100.00%> (-0.04%) ⬇️
Py-3.12.1 96.55% <100.00%> (-0.04%) ⬇️
Py-3.8.10 94.36% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 96.70% <100.00%> (ø)
Py-3.9.13 94.37% <100.00%> (+<0.01%) ⬆️
Py-3.9.18 96.76% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.14 ?
Py-pypy7.3.15 96.30% <100.00%> (?)
VM-macos 96.61% <100.00%> (-0.20%) ⬇️
VM-ubuntu 96.99% <100.00%> (ø)
VM-windows 94.48% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 5cdc0fc into 3.9 Jan 20, 2024
27 of 31 checks passed
@bdraco bdraco deleted the patchback/backports/3.9/5424c534b16d512145c9c6bd4b6356175d607e74/pr-8033 branch January 20, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant