Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use .coveragerc for TYPE_CHECKING conditions #7930

Merged
merged 2 commits into from
Dec 2, 2023
Merged

Use .coveragerc for TYPE_CHECKING conditions #7930

merged 2 commits into from
Dec 2, 2023

Conversation

Dreamsorcerer
Copy link
Member

No description provided.

@Dreamsorcerer Dreamsorcerer added backport-3.9 backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot labels Dec 2, 2023
@Dreamsorcerer Dreamsorcerer added the bot:chronographer:skip This PR does not need to include a change note label Dec 2, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 2, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (669109f) 97.41% compared to head (e604038) 97.43%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7930      +/-   ##
==========================================
+ Coverage   97.41%   97.43%   +0.01%     
==========================================
  Files         107      107              
  Lines       32359    32353       -6     
  Branches     3754     3751       -3     
==========================================
  Hits        31522    31522              
+ Misses        633      630       -3     
+ Partials      204      201       -3
Flag Coverage Δ
CI-GHA 97.34% <ø> (+0.01%) ⬆️
OS-Linux 97.02% <ø> (+0.01%) ⬆️
OS-Windows 95.51% <ø> (+0.01%) ⬆️
OS-macOS 96.82% <ø> (+0.01%) ⬆️
Py-3.10.11 95.43% <ø> (+0.01%) ⬆️
Py-3.10.13 96.81% <ø> (+0.01%) ⬆️
Py-3.11.6 96.55% <ø> (+0.01%) ⬆️
Py-3.12.0 96.60% <ø> (+0.01%) ⬆️
Py-3.8.10 95.40% <ø> (+0.01%) ⬆️
Py-3.8.18 96.75% <ø> (+0.01%) ⬆️
Py-3.9.13 95.40% <ø> (+0.01%) ⬆️
Py-3.9.18 96.78% <ø> (+<0.01%) ⬆️
Py-pypy7.3.13 96.25% <ø> (+0.01%) ⬆️
VM-macos 96.82% <ø> (+0.01%) ⬆️
VM-ubuntu 97.02% <ø> (+0.01%) ⬆️
VM-windows 95.51% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit 895afa8 into master Dec 2, 2023
31 of 34 checks passed
@Dreamsorcerer Dreamsorcerer deleted the coverage-type-checking branch December 2, 2023 15:55
@patchback Patchback
Copy link
Contributor

patchback bot commented Dec 2, 2023 •
edited
Loading

Backport to 3.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.9/895afa83027cb88b5a99d521cff48b549d325990/pr-7930

Backported as #7931

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 2, 2023
@Dreamsorcerer @patchback
Use .coveragerc for TYPE_CHECKING conditions (#7930)
c821ef8 
(cherry picked from commit 895afa8)
@patchback patchback bot mentioned this pull request Dec 2, 2023
Merged
@patchback Patchback
Copy link
Contributor

patchback bot commented Dec 2, 2023 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/895afa83027cb88b5a99d521cff48b549d325990/pr-7930

Backported as #7932

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 2, 2023
@Dreamsorcerer @patchback
Use .coveragerc for TYPE_CHECKING conditions (#7930)
06f5344 
(cherry picked from commit 895afa8)
@patchback patchback bot mentioned this pull request Dec 2, 2023
Merged
Dreamsorcerer added a commit that referenced this pull request Dec 2, 2023
@patchback @Dreamsorcerer
[PR #7930/895afa83 backport][3.9] Use .coveragerc for TYPE_CHECKING c…
d548b59 
…onditions (#7931)

**This is a backport of PR #7930 as merged into master
(895afa8).**

Co-authored-by: Sam Bull <git@sambull.org>
Dreamsorcerer added a commit that referenced this pull request Dec 2, 2023
@patchback @Dreamsorcerer
[PR #7930/895afa83 backport][3.10] Use .coveragerc for TYPE_CHECKING …
4d03b3b 
…conditions (#7932)

**This is a backport of PR #7930 as merged into master
(895afa8).**

Co-authored-by: Sam Bull <git@sambull.org>
webknjaz
webknjaz reviewed Dec 3, 2023
View reviewed changes
.coveragerc

[report]
exclude_also =
if TYPE_CHECKING
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dreamsorcerer have you tried https://pypi.org/p/covdefaults/ ? It provides better regexes in general, including this one.

xiangxli pushed a commit to xiangxli/aiohttp that referenced this pull request Dec 4, 2023
@Dreamsorcerer
Use .coveragerc for TYPE_CHECKING conditions (aio-libs#7930)
61f3a57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz left review comments

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dreamsorcerer @webknjaz