[PR #6916/abafcdac backport][3.9] Add missing __repr__ to streams.EmptyStreamReader #7106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
**EmptyStreamReader** currently inherits `__repr__` from **StreamReader** , which then tries to access non-existing fields, causing AttributeErrors. The bug causes issues like this in upstream code: miguelgrinberg/python-socketio#1032 This PR adds a custom `__repr__` to EmptyStreamReader to fix the problem. (cherry picked from commit abafcda)
Codecov Report
@@ Coverage Diff @@
## 3.9 #7106 +/- ##
==========================================
+ Coverage 96.89% 97.26% +0.37%
==========================================
Files 103 103
Lines 30258 30261 +3
Branches 3767 3767
==========================================
+ Hits 29317 29433 +116
+ Misses 733 632 -101
+ Partials 208 196 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Dreamsorcerer
deleted the
patchback/backports/3.9/abafcdac6cbef06bc555cb77b1ebe724d2a098ec/pr-6916
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #6916 as merged into master (abafcda).
EmptyStreamReader currently inherits
__repr__from StreamReader , which then tries to access non-existing fields, causing AttributeErrors. The bug causes issues like this in upstream code: miguelgrinberg/python-socketio#1032This PR adds a custom
__repr__to EmptyStreamReader to fix the problem.