Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: Installing frozenlist fails on python3.11-beta.5 #6830

Closed
wants to merge 5 commits into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jul 17, 2022

An on-demand GitHub Action...

name: python_3_11-dev
on:
  workflow_dispatch:
jobs:
  python_3_11-dev:
    strategy:
      fail-fast: false
      matrix:
        package:
          - cchardet  # Passes if cython>=0.29.30
          - frozenlist  # Fails
          - yarl  # Fails
          - git+https://github.com/PyYoshi/cChardet.git  # Passes!!!
          - git+https://github.com/aio-libs/frozenlist.git  # Fails
          - git+https://github.com/aio-libs/yarl.git  # Fails
    runs-on: ubuntu-latest
    steps:
      - uses: actions/setup-python@v4
        with:
          python-version: 3.11-dev
      - run: python3.11 -m pip install --upgrade pip wheel
      - run: python3.11 -m pip install --upgrade Cython>=0.29.30
      - run: python3.11 -m pip install ${{ matrix.package }}

Test a workaround for #6600

aio-libs/yarl#706 (comment)

What do these changes do?

Are there changes in behavior for the user?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@cclauss cclauss requested a review from webknjaz as a code owner July 17, 2022 16:46
@codecov
Copy link

codecov bot commented Jul 17, 2022

Codecov Report

Merging #6830 (836c5ff) into master (0db3362) will increase coverage by 71.67%.
The diff coverage is n/a.

❗ Current head 836c5ff differs from pull request most recent head f214f13. Consider uploading reports for the commit f214f13 to get more accurate results

@@             Coverage Diff             @@
##           master    #6830       +/-   ##
===========================================
+ Coverage   21.76%   93.44%   +71.67%     
===========================================
  Files         104      104               
  Lines       30628    30627        -1     
  Branches     3064     3076       +12     
===========================================
+ Hits         6666    28619    +21953     
+ Misses      23859     1838    -22021     
- Partials      103      170       +67     
Flag Coverage Δ
unit 93.36% <ø> (+71.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/client_ws.py 21.96% <0.00%> (ø)
tests/autobahn/test_autobahn.py 38.33% <0.00%> (+6.66%) ⬆️
tests/test_circular_imports.py 100.00% <0.00%> (+7.69%) ⬆️
aiohttp/abc.py 100.00% <0.00%> (+7.86%) ⬆️
aiohttp/web_exceptions.py 99.52% <0.00%> (+22.27%) ⬆️
tests/conftest.py 68.42% <0.00%> (+25.43%) ⬆️
aiohttp/resolver.py 64.00% <0.00%> (+28.00%) ⬆️
aiohttp/tracing.py 100.00% <0.00%> (+36.12%) ⬆️
tests/test_resolver.py 70.07% <0.00%> (+37.79%) ⬆️
aiohttp/client_exceptions.py 96.66% <0.00%> (+39.16%) ⬆️
... and 85 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@cclauss cclauss changed the title GitHub Actions: Upgrade cython only on Python 3.11 GitHub Actions: python3.11-beta.4 -m pip install --upgrade cchardet fails Jul 17, 2022
@cclauss cclauss requested a review from asvetlov as a code owner July 17, 2022 19:53
@cclauss cclauss changed the title GitHub Actions: python3.11-beta.4 -m pip install --upgrade cchardet fails GitHub Actions: Installing cchardet, frozenlist, yarl fail on python3.11-beta.4 Jul 18, 2022
@cclauss cclauss changed the title GitHub Actions: Installing cchardet, frozenlist, yarl fail on python3.11-beta.4 GitHub Actions: Installing frozenlist and yarl fail on python3.11-beta.4 Jul 19, 2022
@cclauss cclauss changed the title GitHub Actions: Installing frozenlist and yarl fail on python3.11-beta.4 GitHub Actions: Installing frozenlist and yarl fail on python3.11-beta.5 Jul 28, 2022
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@cclauss cclauss changed the title GitHub Actions: Installing frozenlist and yarl fail on python3.11-beta.5 GitHub Actions: Installing frozenlist fail on python3.11-beta.5 Aug 2, 2022
@cclauss cclauss changed the title GitHub Actions: Installing frozenlist fail on python3.11-beta.5 GitHub Actions: Installing frozenlist fails on python3.11-beta.5 Aug 2, 2022
@Dreamsorcerer
Copy link
Member

You might want to revert the mypy version change, I'll fix the new errors in a separate PR.

@cclauss cclauss force-pushed the patch-1 branch 2 times, most recently from 6e67d69 to 21fb023 Compare August 3, 2022 09:41
@owocado
Copy link

owocado commented Aug 3, 2022

I think the original post might need to be updated to mention that pip install of latest version of yarl (>=1.8.1) passes with success on latest python v3.11-dev (3.11.0.beta5) since the OP seems outdated due to # Fails comments on 2 yarl entries.

@cclauss
Copy link
Contributor Author

cclauss commented Aug 3, 2022

@ow0x You are correct.
cython, frozenlist, and yarl have all been updated and release since the original commit message.
The problem now seems to be apipkg which is tested on Py3.11 but seems to fail here.

@cclauss
Copy link
Contributor Author

cclauss commented Aug 3, 2022

Sorry. It will take someone with steadier hands than mine to make this green on Py3.11. I sense that master is not even the correct branch to work on.

@cclauss cclauss closed this Aug 3, 2022
@cclauss cclauss deleted the patch-1 branch August 3, 2022 11:27
@Dreamsorcerer
Copy link
Member

We'll want master working and then the 3.9 branch too (and maybe 3.8 if it's not much extra work).

@Dreamsorcerer
Copy link
Member

I think the apipkg error is caused by an outdated pytest (judging by the error reports pytest-dev/apipkg#30, pytest-dev/py#273, pytest-dev/pytest#9181).

@webknjaz
Copy link
Member

webknjaz commented Aug 3, 2022

I think the apipkg error is caused by an outdated pytest

Yes, confirmed by upgrading it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants