-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Fix statement about setUpAsync()
and tearDownAsync()
#6313
Conversation
Looks like a backwards-incompatible change we made by mistake. |
Codecov Report
@@ Coverage Diff @@
## master #6313 +/- ##
=======================================
Coverage 93.31% 93.31%
=======================================
Files 103 103
Lines 30369 30369
Branches 2731 2731
=======================================
Hits 28340 28340
Misses 1852 1852
Partials 177 177
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
75c7bef
to
f12a4c1
Compare
I agree.
It's something I should do in this PR? Thanks @Dreamsorcerer for your first review! |
Open question, maybe async def tearDownAsync(self):
await foo()
await super().tearDownAsync() Would be more suited than async def tearDownAsync(self):
await super().tearDownAsync()
await foo() ? |
f12a4c1
to
76c85ad
Compare
Since aio-libs#4732, it's wrong to says that `setUpAsync()` and `tearDownAsync()` do nothing and can be overridden without calling `super.setUpAsync()` and `super.tearDownAsync()`.
76c85ad
to
863182e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Backport to 3.8: 💚 backport PR created✅ Backport PR branch: Backported as #6317 🤖 @patchback |
Backport to 3.9: 💚 backport PR created✅ Backport PR branch: Backported as #6318 🤖 @patchback |
Since #4732, it's wrong to says that
setUpAsync()
andtearDownAsync()
do nothing and can be overridden withoutcalling
super.setUpAsync()
andsuper.tearDownAsync()
.What do these changes do?
Fix documentation
Are there changes in behavior for the user?
No
Related issue number
None
Checklist
Only docs.
Remark:
My rst preview wasn't working, I hope there is no rst mistakes.